b000dfbd42
Now we have error_setg() we can improve the error message emitted if you attempt to set a property of a device after the device is realized (the previous message was "permission denied" which was not very informative). Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-id: 1364218844-7509-1-git-send-email-peter.maydell@linaro.org Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
79 lines
1.9 KiB
C
79 lines
1.9 KiB
C
#include "hw/qdev.h"
|
|
#include "hw/qdev-addr.h"
|
|
#include "exec/hwaddr.h"
|
|
#include "qapi/qmp/qerror.h"
|
|
#include "qapi/visitor.h"
|
|
|
|
/* --- target physical address --- */
|
|
|
|
static int parse_taddr(DeviceState *dev, Property *prop, const char *str)
|
|
{
|
|
hwaddr *ptr = qdev_get_prop_ptr(dev, prop);
|
|
|
|
*ptr = strtoull(str, NULL, 16);
|
|
return 0;
|
|
}
|
|
|
|
static int print_taddr(DeviceState *dev, Property *prop, char *dest, size_t len)
|
|
{
|
|
hwaddr *ptr = qdev_get_prop_ptr(dev, prop);
|
|
return snprintf(dest, len, "0x" TARGET_FMT_plx, *ptr);
|
|
}
|
|
|
|
static void get_taddr(Object *obj, Visitor *v, void *opaque,
|
|
const char *name, Error **errp)
|
|
{
|
|
DeviceState *dev = DEVICE(obj);
|
|
Property *prop = opaque;
|
|
hwaddr *ptr = qdev_get_prop_ptr(dev, prop);
|
|
int64_t value;
|
|
|
|
value = *ptr;
|
|
visit_type_int64(v, &value, name, errp);
|
|
}
|
|
|
|
static void set_taddr(Object *obj, Visitor *v, void *opaque,
|
|
const char *name, Error **errp)
|
|
{
|
|
DeviceState *dev = DEVICE(obj);
|
|
Property *prop = opaque;
|
|
hwaddr *ptr = qdev_get_prop_ptr(dev, prop);
|
|
Error *local_err = NULL;
|
|
int64_t value;
|
|
|
|
if (dev->realized) {
|
|
qdev_prop_set_after_realize(dev, name, errp);
|
|
return;
|
|
}
|
|
|
|
visit_type_int64(v, &value, name, &local_err);
|
|
if (local_err) {
|
|
error_propagate(errp, local_err);
|
|
return;
|
|
}
|
|
if ((uint64_t)value <= (uint64_t) ~(hwaddr)0) {
|
|
*ptr = value;
|
|
} else {
|
|
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
|
|
dev->id?:"", name, value, (uint64_t) 0,
|
|
(uint64_t) ~(hwaddr)0);
|
|
}
|
|
}
|
|
|
|
|
|
PropertyInfo qdev_prop_taddr = {
|
|
.name = "taddr",
|
|
.parse = parse_taddr,
|
|
.print = print_taddr,
|
|
.get = get_taddr,
|
|
.set = set_taddr,
|
|
};
|
|
|
|
void qdev_prop_set_taddr(DeviceState *dev, const char *name, hwaddr value)
|
|
{
|
|
Error *errp = NULL;
|
|
object_property_set_int(OBJECT(dev), value, name, &errp);
|
|
assert(!errp);
|
|
|
|
}
|