Right now we have these pairs: - virtio_bus_plug_device/virtio_bus_destroy_device. The first takes a VirtIODevice, the second takes a VirtioBusState - device_plugged/device_unplug callbacks in the VirtioBusClass (here it's just the naming that is inconsistent) - virtio_bus_destroy_device is not called by anyone (and since it calls qdev_free, it would be called by the proxies---but then the callback is useless since the proxies can do whatever they want before calling virtio_bus_destroy_device) And there is a k->init but no k->exit, hence virtio_device_exit is overwritten by subclasses (except virtio-9p). This cleans it up by: - renaming the device_unplug callback to device_unplugged - renaming virtio_bus_plug_device to virtio_bus_device_plugged, matching the callback name - renaming virtio_bus_destroy_device to virtio_bus_device_unplugged, removing the qdev_free, making it take a VirtIODevice and calling it from virtio_device_exit - adding a k->exit callback virtio_device_exit is still overwritten, the next patches will fix that. Cc: qemu-stable@nongnu.org Acked-by: Andreas Faerber <afaerber@suse.de> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			201 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			201 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * VirtioBus
 | 
						|
 *
 | 
						|
 *  Copyright (C) 2012 : GreenSocs Ltd
 | 
						|
 *      http://www.greensocs.com/ , email: info@greensocs.com
 | 
						|
 *
 | 
						|
 *  Developed by :
 | 
						|
 *  Frederic Konrad   <fred.konrad@greensocs.com>
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify
 | 
						|
 * it under the terms of the GNU General Public License as published by
 | 
						|
 * the Free Software Foundation, either version 2 of the License, or
 | 
						|
 * (at your option) any later version.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope that it will be useful,
 | 
						|
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
 * GNU General Public License for more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License along
 | 
						|
 * with this program; if not, see <http://www.gnu.org/licenses/>.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "hw/hw.h"
 | 
						|
#include "qemu/error-report.h"
 | 
						|
#include "hw/qdev.h"
 | 
						|
#include "hw/virtio/virtio-bus.h"
 | 
						|
#include "hw/virtio/virtio.h"
 | 
						|
 | 
						|
/* #define DEBUG_VIRTIO_BUS */
 | 
						|
 | 
						|
#ifdef DEBUG_VIRTIO_BUS
 | 
						|
#define DPRINTF(fmt, ...) \
 | 
						|
do { printf("virtio_bus: " fmt , ## __VA_ARGS__); } while (0)
 | 
						|
#else
 | 
						|
#define DPRINTF(fmt, ...) do { } while (0)
 | 
						|
#endif
 | 
						|
 | 
						|
/* A VirtIODevice is being plugged */
 | 
						|
int virtio_bus_device_plugged(VirtIODevice *vdev)
 | 
						|
{
 | 
						|
    DeviceState *qdev = DEVICE(vdev);
 | 
						|
    BusState *qbus = BUS(qdev_get_parent_bus(qdev));
 | 
						|
    VirtioBusState *bus = VIRTIO_BUS(qbus);
 | 
						|
    VirtioBusClass *klass = VIRTIO_BUS_GET_CLASS(bus);
 | 
						|
    DPRINTF("%s: plug device.\n", qbus->name);
 | 
						|
 | 
						|
    if (klass->device_plugged != NULL) {
 | 
						|
        klass->device_plugged(qbus->parent);
 | 
						|
    }
 | 
						|
 | 
						|
    return 0;
 | 
						|
}
 | 
						|
 | 
						|
/* Reset the virtio_bus */
 | 
						|
void virtio_bus_reset(VirtioBusState *bus)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
 | 
						|
    DPRINTF("%s: reset device.\n", qbus->name);
 | 
						|
    if (vdev != NULL) {
 | 
						|
        virtio_reset(vdev);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
/* A VirtIODevice is being unplugged */
 | 
						|
void virtio_bus_device_unplugged(VirtIODevice *vdev)
 | 
						|
{
 | 
						|
    DeviceState *qdev = DEVICE(vdev);
 | 
						|
    BusState *qbus = BUS(qdev_get_parent_bus(qdev));
 | 
						|
    VirtioBusClass *klass = VIRTIO_BUS_GET_CLASS(qbus);
 | 
						|
 | 
						|
    DPRINTF("%s: remove device.\n", qbus->name);
 | 
						|
 | 
						|
    if (vdev != NULL) {
 | 
						|
        if (klass->device_unplugged != NULL) {
 | 
						|
            klass->device_unplugged(qbus->parent);
 | 
						|
        }
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
/* Get the device id of the plugged device. */
 | 
						|
uint16_t virtio_bus_get_vdev_id(VirtioBusState *bus)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    assert(vdev != NULL);
 | 
						|
    return vdev->device_id;
 | 
						|
}
 | 
						|
 | 
						|
/* Get the config_len field of the plugged device. */
 | 
						|
size_t virtio_bus_get_vdev_config_len(VirtioBusState *bus)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    assert(vdev != NULL);
 | 
						|
    return vdev->config_len;
 | 
						|
}
 | 
						|
 | 
						|
/* Get the features of the plugged device. */
 | 
						|
uint32_t virtio_bus_get_vdev_features(VirtioBusState *bus,
 | 
						|
                                    uint32_t requested_features)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    VirtioDeviceClass *k;
 | 
						|
 | 
						|
    assert(vdev != NULL);
 | 
						|
    k = VIRTIO_DEVICE_GET_CLASS(vdev);
 | 
						|
    assert(k->get_features != NULL);
 | 
						|
    return k->get_features(vdev, requested_features);
 | 
						|
}
 | 
						|
 | 
						|
/* Set the features of the plugged device. */
 | 
						|
void virtio_bus_set_vdev_features(VirtioBusState *bus,
 | 
						|
                                      uint32_t requested_features)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    VirtioDeviceClass *k;
 | 
						|
 | 
						|
    assert(vdev != NULL);
 | 
						|
    k = VIRTIO_DEVICE_GET_CLASS(vdev);
 | 
						|
    if (k->set_features != NULL) {
 | 
						|
        k->set_features(vdev, requested_features);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
/* Get bad features of the plugged device. */
 | 
						|
uint32_t virtio_bus_get_vdev_bad_features(VirtioBusState *bus)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    VirtioDeviceClass *k;
 | 
						|
 | 
						|
    assert(vdev != NULL);
 | 
						|
    k = VIRTIO_DEVICE_GET_CLASS(vdev);
 | 
						|
    if (k->bad_features != NULL) {
 | 
						|
        return k->bad_features(vdev);
 | 
						|
    } else {
 | 
						|
        return 0;
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
/* Get config of the plugged device. */
 | 
						|
void virtio_bus_get_vdev_config(VirtioBusState *bus, uint8_t *config)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    VirtioDeviceClass *k;
 | 
						|
 | 
						|
    assert(vdev != NULL);
 | 
						|
    k = VIRTIO_DEVICE_GET_CLASS(vdev);
 | 
						|
    if (k->get_config != NULL) {
 | 
						|
        k->get_config(vdev, config);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
/* Set config of the plugged device. */
 | 
						|
void virtio_bus_set_vdev_config(VirtioBusState *bus, uint8_t *config)
 | 
						|
{
 | 
						|
    VirtIODevice *vdev = virtio_bus_get_device(bus);
 | 
						|
    VirtioDeviceClass *k;
 | 
						|
 | 
						|
    assert(vdev != NULL);
 | 
						|
    k = VIRTIO_DEVICE_GET_CLASS(vdev);
 | 
						|
    if (k->set_config != NULL) {
 | 
						|
        k->set_config(vdev, config);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
static char *virtio_bus_get_dev_path(DeviceState *dev)
 | 
						|
{
 | 
						|
    BusState *bus = qdev_get_parent_bus(dev);
 | 
						|
    DeviceState *proxy = DEVICE(bus->parent);
 | 
						|
    return qdev_get_dev_path(proxy);
 | 
						|
}
 | 
						|
 | 
						|
static char *virtio_bus_get_fw_dev_path(DeviceState *dev)
 | 
						|
{
 | 
						|
    return NULL;
 | 
						|
}
 | 
						|
 | 
						|
static void virtio_bus_class_init(ObjectClass *klass, void *data)
 | 
						|
{
 | 
						|
    BusClass *bus_class = BUS_CLASS(klass);
 | 
						|
    bus_class->get_dev_path = virtio_bus_get_dev_path;
 | 
						|
    bus_class->get_fw_dev_path = virtio_bus_get_fw_dev_path;
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo virtio_bus_info = {
 | 
						|
    .name = TYPE_VIRTIO_BUS,
 | 
						|
    .parent = TYPE_BUS,
 | 
						|
    .instance_size = sizeof(VirtioBusState),
 | 
						|
    .abstract = true,
 | 
						|
    .class_size = sizeof(VirtioBusClass),
 | 
						|
    .class_init = virtio_bus_class_init
 | 
						|
};
 | 
						|
 | 
						|
static void virtio_register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&virtio_bus_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(virtio_register_types)
 |