Markus Armbruster d09acb9b5e fw_cfg: Splash image loader can overrun a stack variable, fix
read_splashfile() passes the address of an int variable as size_t *
parameter to g_file_get_contents(), with a cast to gag the compiler.

No problem on machines where sizeof(size_t) == sizeof(int).

Happens to work on my x86_64 box (64 bit little endian): the least
significant 32 bits of the file size end up in the right place
(caller's variable file_size), and the most significant 32 bits
clobber a place that gets assigned to before its next use (caller's
variable file_type).

I'd expect it to break on a 64 bit big-endian box.

Fix up the variable types and drop the problematic cast.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
2013-01-26 13:23:33 +00:00
..
2013-01-14 10:23:50 -06:00
2013-01-17 10:51:11 +01:00
2013-01-14 10:23:50 -06:00
2013-01-26 13:15:37 +00:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:30 +01:00
2012-11-01 19:49:45 +01:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2013-01-10 15:11:53 -06:00
2012-06-21 16:06:11 +00:00
2013-01-10 15:11:53 -06:00
2012-12-17 13:02:26 +02:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:31 +01:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-03-14 22:20:26 +01:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:31 +01:00
2012-10-23 08:58:25 -05:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2012-10-10 11:13:32 +10:00
2012-10-10 11:13:32 +10:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-07 12:57:24 +01:00
2013-01-07 12:57:24 +01:00
2012-12-19 08:32:39 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-11-26 14:25:42 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-14 10:23:50 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-15 18:26:18 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2012-10-23 08:58:25 -05:00
2013-01-10 15:11:53 -06:00
2013-01-26 13:15:37 +00:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2012-11-12 16:42:56 +01:00
2012-03-14 22:20:26 +01:00
2012-03-14 22:20:26 +01:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:31 +01:00
2012-11-10 13:49:20 +00:00
2012-10-23 08:58:25 -05:00
2012-10-23 08:58:25 -05:00
2012-10-23 08:58:25 -05:00
2012-12-14 13:12:56 +01:00
2012-07-27 21:13:01 +00:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-14 08:59:39 +01:00
2013-01-17 10:24:52 -02:00
2013-01-14 10:23:50 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-12-04 13:52:43 +01:00
2012-12-04 13:52:43 +01:00
2012-10-23 08:58:25 -05:00
2013-01-18 19:06:57 +01:00
2012-04-12 11:14:29 +01:00
2012-10-23 08:58:25 -05:00
2012-10-23 08:58:25 -05:00
2012-10-23 08:58:25 -05:00
2013-01-15 04:09:13 +01:00
2012-12-19 08:31:31 +01:00
2013-01-15 18:27:00 -06:00
2013-01-22 11:01:07 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:31 +01:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:32:39 +01:00
2013-01-10 15:11:53 -06:00
2013-01-14 10:23:50 -06:00
2013-01-24 09:45:03 -06:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2013-01-10 15:11:53 -06:00
2012-10-23 08:58:25 -05:00
2012-10-23 08:58:25 -05:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-10-10 11:13:32 +10:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-16 12:14:20 -06:00
2013-01-16 12:14:20 -06:00
2013-01-10 15:11:53 -06:00
2013-01-17 10:24:52 -02:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-07 19:42:23 +02:00
2013-01-07 19:42:23 +02:00
2013-01-07 19:42:23 +02:00
2013-01-07 19:42:23 +02:00
2013-01-07 19:42:23 +02:00
2012-12-19 08:31:29 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2012-12-19 08:31:29 +01:00
2013-01-10 15:11:53 -06:00
2012-12-17 13:02:26 +02:00
2013-01-10 15:11:53 -06:00
2013-01-15 04:09:13 +01:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-10 15:11:53 -06:00
2013-01-15 18:26:18 -06:00
2013-01-10 15:11:53 -06:00