Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the Error typedef. Since then, we've moved to include qemu/osdep.h everywhere. Its file comment explains: "To avoid getting into possible circular include dependencies, this file should not include any other QEMU headers, with the exceptions of config-host.h, compiler.h, os-posix.h and os-win32.h, all of which are doing a similar job to this file and are under similar constraints." qapi/error.h doesn't do a similar job, and it doesn't adhere to similar constraints: it includes qapi-types.h. That's in excess of 100KiB of crap most .c files don't actually need. Add the typedef to qemu/typedefs.h, and include that instead of qapi/error.h. Include qapi/error.h in .c files that need it and don't get it now. Include qapi-types.h in qom/object.h for uint16List. Update scripts/clean-includes accordingly. Update it further to match reality: replace config.h by config-target.h, add sysemu/os-posix.h, sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h comment quoted above similarly. This reduces the number of objects depending on qapi/error.h from "all of them" to less than a third. Unfortunately, the number depending on qapi-types.h shrinks only a little. More work is needed for that one. Signed-off-by: Markus Armbruster <armbru@redhat.com> [Fix compilation without the spice devel packages. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			124 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			124 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU I/O channel file test
 | 
						|
 *
 | 
						|
 * Copyright (c) 2015 Red Hat, Inc.
 | 
						|
 *
 | 
						|
 * This library is free software; you can redistribute it and/or
 | 
						|
 * modify it under the terms of the GNU Lesser General Public
 | 
						|
 * License as published by the Free Software Foundation; either
 | 
						|
 * version 2 of the License, or (at your option) any later version.
 | 
						|
 *
 | 
						|
 * This library is distributed in the hope that it will be useful,
 | 
						|
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 | 
						|
 * Lesser General Public License for more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU Lesser General Public
 | 
						|
 * License along with this library; if not, see <http://www.gnu.org/licenses/>.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "io/channel-file.h"
 | 
						|
#include "io/channel-util.h"
 | 
						|
#include "io-channel-helpers.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
 | 
						|
static void test_io_channel_file(void)
 | 
						|
{
 | 
						|
    QIOChannel *src, *dst;
 | 
						|
    QIOChannelTest *test;
 | 
						|
 | 
						|
#define TEST_FILE "tests/test-io-channel-file.txt"
 | 
						|
    unlink(TEST_FILE);
 | 
						|
    src = QIO_CHANNEL(qio_channel_file_new_path(
 | 
						|
                          TEST_FILE,
 | 
						|
                          O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0600,
 | 
						|
                          &error_abort));
 | 
						|
    dst = QIO_CHANNEL(qio_channel_file_new_path(
 | 
						|
                          TEST_FILE,
 | 
						|
                          O_RDONLY | O_BINARY, 0,
 | 
						|
                          &error_abort));
 | 
						|
 | 
						|
    test = qio_channel_test_new();
 | 
						|
    qio_channel_test_run_writer(test, src);
 | 
						|
    qio_channel_test_run_reader(test, dst);
 | 
						|
    qio_channel_test_validate(test);
 | 
						|
 | 
						|
    unlink(TEST_FILE);
 | 
						|
    object_unref(OBJECT(src));
 | 
						|
    object_unref(OBJECT(dst));
 | 
						|
}
 | 
						|
 | 
						|
 | 
						|
static void test_io_channel_fd(void)
 | 
						|
{
 | 
						|
    QIOChannel *ioc;
 | 
						|
    int fd = -1;
 | 
						|
 | 
						|
#define TEST_FILE "tests/test-io-channel-file.txt"
 | 
						|
    fd = open(TEST_FILE, O_CREAT | O_TRUNC | O_WRONLY, 0600);
 | 
						|
    g_assert_cmpint(fd, >, -1);
 | 
						|
 | 
						|
    ioc = qio_channel_new_fd(fd, &error_abort);
 | 
						|
 | 
						|
    g_assert_cmpstr(object_get_typename(OBJECT(ioc)),
 | 
						|
                    ==,
 | 
						|
                    TYPE_QIO_CHANNEL_FILE);
 | 
						|
 | 
						|
    unlink(TEST_FILE);
 | 
						|
    object_unref(OBJECT(ioc));
 | 
						|
}
 | 
						|
 | 
						|
 | 
						|
#ifndef _WIN32
 | 
						|
static void test_io_channel_pipe(bool async)
 | 
						|
{
 | 
						|
    QIOChannel *src, *dst;
 | 
						|
    QIOChannelTest *test;
 | 
						|
    int fd[2];
 | 
						|
 | 
						|
    if (pipe(fd) < 0) {
 | 
						|
        perror("pipe");
 | 
						|
        abort();
 | 
						|
    }
 | 
						|
 | 
						|
    src = QIO_CHANNEL(qio_channel_file_new_fd(fd[1]));
 | 
						|
    dst = QIO_CHANNEL(qio_channel_file_new_fd(fd[0]));
 | 
						|
 | 
						|
    test = qio_channel_test_new();
 | 
						|
    qio_channel_test_run_threads(test, async, src, dst);
 | 
						|
    qio_channel_test_validate(test);
 | 
						|
 | 
						|
    object_unref(OBJECT(src));
 | 
						|
    object_unref(OBJECT(dst));
 | 
						|
}
 | 
						|
 | 
						|
 | 
						|
static void test_io_channel_pipe_async(void)
 | 
						|
{
 | 
						|
    test_io_channel_pipe(true);
 | 
						|
}
 | 
						|
 | 
						|
static void test_io_channel_pipe_sync(void)
 | 
						|
{
 | 
						|
    test_io_channel_pipe(false);
 | 
						|
}
 | 
						|
#endif /* ! _WIN32 */
 | 
						|
 | 
						|
 | 
						|
int main(int argc, char **argv)
 | 
						|
{
 | 
						|
    module_call_init(MODULE_INIT_QOM);
 | 
						|
 | 
						|
    g_test_init(&argc, &argv, NULL);
 | 
						|
 | 
						|
    g_test_add_func("/io/channel/file", test_io_channel_file);
 | 
						|
    g_test_add_func("/io/channel/file/fd", test_io_channel_fd);
 | 
						|
#ifndef _WIN32
 | 
						|
    g_test_add_func("/io/channel/pipe/sync", test_io_channel_pipe_sync);
 | 
						|
    g_test_add_func("/io/channel/pipe/async", test_io_channel_pipe_async);
 | 
						|
#endif
 | 
						|
    return g_test_run();
 | 
						|
}
 |