hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: libsas: Grab the ATA port lock in sas_ata_device_link_abort()

Browse Source 
commit a67aad57d9aee41180aff36e54cb72fe4b8d5a5a upstream.

Grab the ATA port lock in sas_ata_device_link_abort() before calling
ata_link_abort() as outlined in this function's locking requirements.

Fixes: 44112922674b ("scsi: libsas: Add sas_ata_device_link_abort()")
Signed-off-by: Xingui Yang <yangxingui@huawei.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Xingui Yang 2022-12-21 01:52:03 +00:00 committed by Greg Kroah-Hartman
parent 6dc7e36334
commit 1887a4faff
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/scsi/libsas/sas_ata.c
View File

@ -890,7 +890,9 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
{ {
struct ata_port *ap = device->sata_dev.ap; struct ata_port *ap = device->sata_dev.ap;
struct ata_link *link = &ap->link; struct ata_link *link = &ap->link;
unsigned long flags;
spin_lock_irqsave(ap->lock, flags);
device->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */ device->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
device->sata_dev.fis[3] = ATA_ABORTED; /* tf error */ device->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
@ -898,6 +900,7 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
if (force_reset) if (force_reset)
link->eh_info.action |= ATA_EH_RESET; link->eh_info.action |= ATA_EH_RESET;
ata_link_abort(link); ata_link_abort(link);
spin_unlock_irqrestore(ap->lock, flags);
} }
EXPORT_SYMBOL_GPL(sas_ata_device_link_abort); EXPORT_SYMBOL_GPL(sas_ata_device_link_abort);