hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug: Remove redundant condition check in report_bug

Browse Source 
report_bug() will return early if it cannot find a bug corresponding to
the provided address. The subsequent test for the bug will always be
true so remove it.

Fixes: 1b4cfe3c0a30d ("lib/bug.c: exclude non-BUG/WARN exceptions from report_bug()")
Signed-off-by: Andrew Scull <ascull@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210318143311.839894-2-ascull@google.com
This commit is contained in:
Andrew Scull 2021-03-18 14:33:07 +00:00 committed by Marc Zyngier
parent 1e28eed176
commit 3ad1a6cb0a
1 changed files with 13 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/bug.c
View File

@ -155,9 +155,7 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
file = NULL; file = NULL;
line = 0; line = 0;
warning = 0;
if (bug) {
#ifdef CONFIG_DEBUG_BUGVERBOSE #ifdef CONFIG_DEBUG_BUGVERBOSE
#ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
file = bug->file; file = bug->file;
@ -179,7 +177,6 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
*/ */
bug->flags |= BUGFLAG_DONE; bug->flags |= BUGFLAG_DONE;
} }
}
/* /*
* BUG() and WARN_ON() families don't print a custom debug message * BUG() and WARN_ON() families don't print a custom debug message