hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: pca953x: Make platform teardown callback return void

Browse Source 
All platforms that provide a teardown callback return 0. New users are
supposed to not make use of platform support, so there is no
functionality lost.

This patch is a preparation for making i2c remove callbacks return void.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Uwe Kleine-König 2022-08-15 10:02:29 +02:00 committed by Wolfram Sang
parent 22a2343689
commit 6a8f359c31
3 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/arm/mach-davinci/board-da850-evm.c
View File

@ -516,8 +516,8 @@ exp_setup_sela_fail:
return ret; return ret;
} }
static int da850_evm_ui_expander_teardown(struct i2c_client *client, static void da850_evm_ui_expander_teardown(struct i2c_client *client,
unsigned gpio, unsigned ngpio, void *c) unsigned gpio, unsigned ngpio, void *c)
{ {
platform_device_unregister(&da850_evm_ui_keys_device); platform_device_unregister(&da850_evm_ui_keys_device);
@ -529,8 +529,6 @@ static int da850_evm_ui_expander_teardown(struct i2c_client *client,
gpio_free(gpio + DA850_EVM_UI_EXP_SEL_C); gpio_free(gpio + DA850_EVM_UI_EXP_SEL_C);
gpio_free(gpio + DA850_EVM_UI_EXP_SEL_B); gpio_free(gpio + DA850_EVM_UI_EXP_SEL_B);
gpio_free(gpio + DA850_EVM_UI_EXP_SEL_A); gpio_free(gpio + DA850_EVM_UI_EXP_SEL_A);
return 0;
} }
/* assign the baseboard expander's GPIOs after the UI board's */ /* assign the baseboard expander's GPIOs after the UI board's */
@ -697,13 +695,11 @@ io_exp_setup_sw_fail:
return ret; return ret;
} }
static int da850_evm_bb_expander_teardown(struct i2c_client *client, static void da850_evm_bb_expander_teardown(struct i2c_client *client,
unsigned gpio, unsigned ngpio, void *c) unsigned gpio, unsigned ngpio, void *c)
{ {
platform_device_unregister(&da850_evm_bb_leds_device); platform_device_unregister(&da850_evm_bb_leds_device);
platform_device_unregister(&da850_evm_bb_keys_device); platform_device_unregister(&da850_evm_bb_keys_device);
return 0;
} }
static struct pca953x_platform_data da850_evm_ui_expander_info = { static struct pca953x_platform_data da850_evm_ui_expander_info = {

11
drivers/gpio/gpio-pca953x.c
View File

@ -1105,20 +1105,15 @@ static int pca953x_remove(struct i2c_client *client)
{ {
struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev); struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
struct pca953x_chip *chip = i2c_get_clientdata(client); struct pca953x_chip *chip = i2c_get_clientdata(client);
int ret;
if (pdata && pdata->teardown) { if (pdata && pdata->teardown) {
ret = pdata->teardown(client, chip->gpio_chip.base, pdata->teardown(client, chip->gpio_chip.base,
chip->gpio_chip.ngpio, pdata->context); chip->gpio_chip.ngpio, pdata->context);
if (ret < 0)
dev_err(&client->dev, "teardown failed, %d\n", ret);
} else {
ret = 0;
} }
regulator_disable(chip->regulator); regulator_disable(chip->regulator);
return ret; return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP

2
include/linux/platform_data/pca953x.h
View File

@ -22,7 +22,7 @@ struct pca953x_platform_data {
int (*setup)(struct i2c_client *client, int (*setup)(struct i2c_client *client,
unsigned gpio, unsigned ngpio, unsigned gpio, unsigned ngpio,
void *context); void *context);
int (*teardown)(struct i2c_client *client, void (*teardown)(struct i2c_client *client,
unsigned gpio, unsigned ngpio, unsigned gpio, unsigned ngpio,
void *context); void *context);
const char *const *names; const char *const *names;