hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

base/node.c: initialize the accessor list before registering

Browse Source 
[ Upstream commit 48b5928e18dc27e05cab3dc4c78cd8a15baaf1e5 ]

The current code registers the node as available in the node array
before initializing the accessor list.  This makes it so that
anything which might access the accessor list as a result of
allocations will cause an undefined memory access.

In one example, an extension to access hmat data during interleave
caused this undefined access as a result of a bulk allocation
that occurs during node initialization but before the accessor
list is initialized.

Initialize the accessor list before making the node generally
available to the global system.

Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes")
Signed-off-by: Gregory Price <gregory.price@memverge.com>
Link: https://lore.kernel.org/r/20231030044239.971756-1-gregory.price@memverge.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Gregory Price 2023-10-30 00:42:39 -04:00 committed by Greg Kroah-Hartman
parent d5ef7480d6
commit 76be69716c
1 changed files with 6 additions and 3 deletions

9
drivers/base/node.c

@ -859,11 +859,15 @@ int __register_one_node(int nid)
{ {
int error; int error;
int cpu; int cpu;
struct node *node;
node_devices[nid] = kzalloc(sizeof(struct node), GFP_KERNEL); node = kzalloc(sizeof(struct node), GFP_KERNEL);
if (!node_devices[nid]) if (!node)
return -ENOMEM; return -ENOMEM;
INIT_LIST_HEAD(&node->access_list);
node_devices[nid] = node;
error = register_node(node_devices[nid], nid); error = register_node(node_devices[nid], nid);
/* link cpu under this node */ /* link cpu under this node */
@ -872,7 +876,6 @@ int __register_one_node(int nid)
register_cpu_under_node(cpu, nid); register_cpu_under_node(cpu, nid);
} }
INIT_LIST_HEAD(&node_devices[nid]->access_list);
node_init_caches(nid); node_init_caches(nid);
return error; return error;