hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ACPI: platform-profile: Introduce object pointers to callbacks

Browse Source 
Add an object pointer to handler callbacks to avoid the need for
drivers to have a global variable to get to their driver-data
struct.

Link: https://lore.kernel.org/linux-acpi/6a29f338-d9e4-150c-81dd-2ffb54f5bc35@redhat.com/
Link: https://lore.kernel.org/r/20210114073429.176462-3-jiaxun.yang@flygoat.com
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Jiaxun Yang 2021-01-25 12:59:57 +01:00 committed by Rafael J. Wysocki
parent 9d56653d14
commit 84f9017c37
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/acpi/platform_profile.c
View File

@ -64,7 +64,7 @@ static ssize_t platform_profile_show(struct device *dev,
return -ENODEV; return -ENODEV;
} }
err = cur_profile->profile_get(&profile); err = cur_profile->profile_get(cur_profile, &profile);
mutex_unlock(&profile_lock); mutex_unlock(&profile_lock);
if (err) if (err)
return err; return err;
@ -104,7 +104,7 @@ static ssize_t platform_profile_store(struct device *dev,
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }
err = cur_profile->profile_set(i); err = cur_profile->profile_set(cur_profile, i);
mutex_unlock(&profile_lock); mutex_unlock(&profile_lock);
if (err) if (err)
return err; return err;

6
include/linux/platform_profile.h
View File

@ -28,8 +28,10 @@ enum platform_profile_option {
struct platform_profile_handler { struct platform_profile_handler {
unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)]; unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
int (*profile_get)(enum platform_profile_option *profile); int (*profile_get)(struct platform_profile_handler *pprof,
int (*profile_set)(enum platform_profile_option profile); enum platform_profile_option *profile);
int (*profile_set)(struct platform_profile_handler *pprof,
enum platform_profile_option profile);
}; };
int platform_profile_register(struct platform_profile_handler *pprof); int platform_profile_register(struct platform_profile_handler *pprof);