hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tty: Make ldisc ->set_termios() old ktermios const

Browse Source 
There should be no reason to adjust old ktermios which is going to get
discarded anyway.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220816115739.10928-6-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ilpo Järvinen 2022-08-16 14:57:36 +03:00 committed by Greg Kroah-Hartman
parent d15f89d997
commit 8b7d2d95cf
2 changed files with 3 additions and 3 deletions
drivers/tty
n_tty.c
include/linux
tty_ldisc.h

2
drivers/tty/n_tty.c

@ -1758,7 +1758,7 @@ static int n_tty_receive_buf2(struct tty_struct *tty, const unsigned char *cp,
* *
* Locking: Caller holds @tty->termios_rwsem * Locking: Caller holds @tty->termios_rwsem
*/ */
static void n_tty_set_termios(struct tty_struct *tty, struct ktermios *old) static void n_tty_set_termios(struct tty_struct *tty, const struct ktermios *old)
{ {
struct n_tty_data *ldata = tty->disc_data; struct n_tty_data *ldata = tty->disc_data;

4
include/linux/tty_ldisc.h

@ -130,7 +130,7 @@ int ldsem_down_write_nested(struct ld_semaphore *sem, int subclass,
* a pointer to wordsize-sensitive structure belongs here, but most of * a pointer to wordsize-sensitive structure belongs here, but most of
* ldiscs will happily leave it %NULL. * ldiscs will happily leave it %NULL.
* *
* @set_termios: [TTY] ``void ()(struct tty_struct *tty, struct ktermios *old)`` * @set_termios: [TTY] ``void ()(struct tty_struct *tty, const struct ktermios *old)``
* *
* This function notifies the line discpline that a change has been made * This function notifies the line discpline that a change has been made
* to the termios structure. * to the termios structure.
@ -227,7 +227,7 @@ struct tty_ldisc_ops {
unsigned long arg); unsigned long arg);
int (*compat_ioctl)(struct tty_struct *tty, unsigned int cmd, int (*compat_ioctl)(struct tty_struct *tty, unsigned int cmd,
unsigned long arg); unsigned long arg);
void (*set_termios)(struct tty_struct *tty, struct ktermios *old); void (*set_termios)(struct tty_struct *tty, const struct ktermios *old);
__poll_t (*poll)(struct tty_struct *tty, struct file *file, __poll_t (*poll)(struct tty_struct *tty, struct file *file,
struct poll_table_struct *wait); struct poll_table_struct *wait);
void (*hangup)(struct tty_struct *tty); void (*hangup)(struct tty_struct *tty);