hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

firmware: arm_scmi: Fix call site of scmi_notification_exit

Browse Source 
Call scmi_notification_exit() only when SCMI platform driver instance has
been really successfully removed.

Link: https://lore.kernel.org/r/20210112191326.29091-1-cristian.marussi@arm.com
Fixes: 6b8a69131dc63 ("firmware: arm_scmi: Enable notification core")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
[sudeep.holla: Move the call outside the list mutex locking]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
This commit is contained in:
Cristian Marussi 2021-01-12 19:13:26 +00:00 committed by Sudeep Holla
parent 6054d97ab5
commit a90b6543bf
1 changed files with 2 additions and 2 deletions

4
drivers/firmware/arm_scmi/driver.c

@ -848,8 +848,6 @@ static int scmi_remove(struct platform_device *pdev)
struct scmi_info *info = platform_get_drvdata(pdev); struct scmi_info *info = platform_get_drvdata(pdev);
struct idr *idr = &info->tx_idr; struct idr *idr = &info->tx_idr;
scmi_notification_exit(&info->handle);
mutex_lock(&scmi_list_mutex); mutex_lock(&scmi_list_mutex);
if (info->users) if (info->users)
ret = -EBUSY; ret = -EBUSY;
@ -860,6 +858,8 @@ static int scmi_remove(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
scmi_notification_exit(&info->handle);
/* Safe to free channels since no more users */ /* Safe to free channels since no more users */
ret = idr_for_each(idr, info->desc->ops->chan_free, idr); ret = idr_for_each(idr, info->desc->ops->chan_free, idr);
idr_destroy(&info->tx_idr); idr_destroy(&info->tx_idr);