trace_events_hist: add check for return value of 'create_hist_field'
commit 8b152e9150d07a885f95e1fd401fc81af202d9a4 upstream. Function 'create_hist_field' is called recursively at trace_events_hist.c:1954 and can return NULL-value that's why we have to check it to avoid null pointer dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Link: https://lkml.kernel.org/r/20230111120409.4111-1-n.petrova@fintech.ru Cc: stable@vger.kernel.org Fixes: 30350d65ac56 ("tracing: Add variable support to hist triggers") Signed-off-by: Natalia Petrova <n.petrova@fintech.ru> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
198c83963f
commit
b4e7e81b4f
@ -1975,6 +1975,8 @@ static struct hist_field *create_hist_field(struct hist_trigger_data *hist_data,
|
|||||||
hist_field->fn_num = flags & HIST_FIELD_FL_LOG2 ? HIST_FIELD_FN_LOG2 :
|
hist_field->fn_num = flags & HIST_FIELD_FL_LOG2 ? HIST_FIELD_FN_LOG2 :
|
||||||
HIST_FIELD_FN_BUCKET;
|
HIST_FIELD_FN_BUCKET;
|
||||||
hist_field->operands[0] = create_hist_field(hist_data, field, fl, NULL);
|
hist_field->operands[0] = create_hist_field(hist_data, field, fl, NULL);
|
||||||
|
if (!hist_field->operands[0])
|
||||||
|
goto free;
|
||||||
hist_field->size = hist_field->operands[0]->size;
|
hist_field->size = hist_field->operands[0]->size;
|
||||||
hist_field->type = kstrdup_const(hist_field->operands[0]->type, GFP_KERNEL);
|
hist_field->type = kstrdup_const(hist_field->operands[0]->type, GFP_KERNEL);
|
||||||
if (!hist_field->type)
|
if (!hist_field->type)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user