hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tty: fix read of tty->pgrp outside of ctrl_lock

Browse Source 
The intention was clearly to use the tty_pgrp local variable rather than
re-read tty->pgrp outside of ctrl_lock, so do that.

This bug was introduced by commit 2812d9e9fd94 ("tty: Combine
SIGTTOU/SIGTTIN handling").

Signed-off-by: David Emett <dave@sp4m.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Emett 2019-03-10 21:43:47 +00:00 committed by Greg Kroah-Hartman
parent 3adf2aa8af
commit cf90c06f81
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/tty_jobctrl.c
View File

@ -44,7 +44,7 @@ int __tty_check_change(struct tty_struct *tty, int sig)
tty_pgrp = tty->pgrp; tty_pgrp = tty->pgrp;
spin_unlock_irqrestore(&tty->ctrl_lock, flags); spin_unlock_irqrestore(&tty->ctrl_lock, flags);
if (tty_pgrp && pgrp != tty->pgrp) { if (tty_pgrp && pgrp != tty_pgrp) {
if (is_ignored(sig)) { if (is_ignored(sig)) {
if (sig == SIGTTIN) if (sig == SIGTTIN)
ret = -EIO; ret = -EIO;