hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: SOF: ipc4-mtrace: prevent underflow in sof_ipc4_priority_mask_dfs_write()

Browse Source 
[ Upstream commit ea57680af47587397f5005d7758022441ed66d54 ]

The "id" comes from the user.  Change the type to unsigned to prevent
an array underflow.

Fixes: f4ea22f7aa75 ("ASoC: SOF: ipc4: Add support for mtrace log extraction")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/Y8laruWOEwOC/dx9@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter 2023-01-19 17:58:54 +03:00 committed by Greg Kroah-Hartman
parent 4ea7f83314
commit d52f34784e
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sound/soc/sof/ipc4-mtrace.c
View File

@ -344,9 +344,10 @@ static ssize_t sof_ipc4_priority_mask_dfs_write(struct file *file,
size_t count, loff_t *ppos) size_t count, loff_t *ppos)
{ {
struct sof_mtrace_priv *priv = file->private_data; struct sof_mtrace_priv *priv = file->private_data;
int id, ret; unsigned int id;
char *buf; char *buf;
u32 mask; u32 mask;
int ret;
/* /*
* To update Nth mask entry, write: * To update Nth mask entry, write:
@ -357,9 +358,9 @@ static ssize_t sof_ipc4_priority_mask_dfs_write(struct file *file,
if (IS_ERR(buf)) if (IS_ERR(buf))
return PTR_ERR(buf); return PTR_ERR(buf);
ret = sscanf(buf, "%d,0x%x", &id, &mask); ret = sscanf(buf, "%u,0x%x", &id, &mask);
if (ret != 2) { if (ret != 2) {
ret = sscanf(buf, "%d,%x", &id, &mask); ret = sscanf(buf, "%u,%x", &id, &mask);
if (ret != 2) { if (ret != 2) {
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;