hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libceph: use swap() macro instead of taking tmp variable

Browse Source 
Fix the following coccicheck warning:
net/ceph/crush/mapper.c:1077:8-9: WARNING opportunity for swap()

by using swap() for the swapping of variable values and drop
the tmp variable that is not needed any more.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Guo Zhengkui 2022-04-12 14:46:20 +08:00 committed by Ilya Dryomov
parent 261998c300
commit d9d58f0402
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/ceph/crush/mapper.c
View File

@ -906,7 +906,6 @@ int crush_do_rule(const struct crush_map *map,
int recurse_to_leaf; int recurse_to_leaf;
int wsize = 0; int wsize = 0;
int osize; int osize;
int *tmp;
const struct crush_rule *rule; const struct crush_rule *rule;
__u32 step; __u32 step;
int i, j; int i, j;
@ -1073,9 +1072,7 @@ int crush_do_rule(const struct crush_map *map,
memcpy(o, c, osize*sizeof(*o)); memcpy(o, c, osize*sizeof(*o));
/* swap o and w arrays */ /* swap o and w arrays */
tmp = o; swap(o, w);
o = w;
w = tmp;
wsize = osize; wsize = osize;
break; break;