hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: hisilicon/qm - add missing pci_dev_put() in q_num_set()

Browse Source 
[ Upstream commit cc7710d0d4ebc6998f04035cde4f32c5ddbe9d7f ]

pci_get_device() will increase the reference count for the returned
pci_dev. We need to use pci_dev_put() to decrease the reference count
before q_num_set() returns.

Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: Weili Qian <qianweili@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Xiongfeng Wang 2022-11-11 18:00:36 +08:00 committed by Greg Kroah-Hartman
parent b5be6724f2
commit f98601f9ab
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/hisi_acc_qm.h
View File

@ -384,14 +384,14 @@ struct hisi_qp {
static inline int q_num_set(const char *val, const struct kernel_param *kp, static inline int q_num_set(const char *val, const struct kernel_param *kp,
unsigned int device) unsigned int device)
{ {
struct pci_dev *pdev = pci_get_device(PCI_VENDOR_ID_HUAWEI, struct pci_dev *pdev;
device, NULL);
u32 n, q_num; u32 n, q_num;
int ret; int ret;
if (!val) if (!val)
return -EINVAL; return -EINVAL;
pdev = pci_get_device(PCI_VENDOR_ID_HUAWEI, device, NULL);
if (!pdev) { if (!pdev) {
q_num = min_t(u32, QM_QNUM_V1, QM_QNUM_V2); q_num = min_t(u32, QM_QNUM_V1, QM_QNUM_V2);
pr_info("No device found currently, suppose queue number is %u\n", pr_info("No device found currently, suppose queue number is %u\n",
@ -401,6 +401,8 @@ static inline int q_num_set(const char *val, const struct kernel_param *kp,
q_num = QM_QNUM_V1; q_num = QM_QNUM_V1;
else else
q_num = QM_QNUM_V2; q_num = QM_QNUM_V2;
pci_dev_put(pdev);
} }
ret = kstrtou32(val, 10, &n); ret = kstrtou32(val, 10, &n);