- fixed buffers size

all changes relevant to exercise a1.3
Backports sst fixes
2025-05-21 14:10:38 +02:00 · 2025-05-12 18:33:41 +02:00 · 2025-04-25 16:23:01 +02:00 · 2025-04-17 20:15:32 +02:00 · 2025-04-17 19:49:51 +02:00 · 2024-05-08 12:34:05 +02:00
8 changed files with 58 additions and 67 deletions
--- a/a1.2.config
+++ b/a1.2.config
@ -1,21 +1,20 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/x86 6.1.134 Kernel Configuration
+# Linux/x86 6.1.55 Kernel Configuration
 #
-CONFIG_CC_VERSION_TEXT="gcc (Debian 12.2.0-14) 12.2.0"
+CONFIG_CC_VERSION_TEXT="gcc (Debian 13.2.0-23) 13.2.0"
 CONFIG_CC_IS_GCC=y
-CONFIG_GCC_VERSION=120200
+CONFIG_GCC_VERSION=130200
 CONFIG_CLANG_VERSION=0
 CONFIG_AS_IS_GNU=y
-CONFIG_AS_VERSION=24000
+CONFIG_AS_VERSION=24200
 CONFIG_LD_IS_BFD=y
-CONFIG_LD_VERSION=24000
+CONFIG_LD_VERSION=24200
 CONFIG_LLD_VERSION=0
 CONFIG_CC_CAN_LINK=y
 CONFIG_CC_CAN_LINK_STATIC=y
 CONFIG_CC_HAS_ASM_GOTO_OUTPUT=y
 CONFIG_CC_HAS_ASM_GOTO_TIED_OUTPUT=y
-CONFIG_GCC_ASM_GOTO_OUTPUT_WORKAROUND=y
 CONFIG_CC_HAS_ASM_INLINE=y
 CONFIG_CC_HAS_NO_PROFILE_FN_ATTR=y
 CONFIG_PAHOLE_VERSION=124
@ -176,7 +175,7 @@ CONFIG_ARCH_SUPPORTS_NUMA_BALANCING=y
 CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH=y
 CONFIG_CC_HAS_INT128=y
 CONFIG_CC_IMPLICIT_FALLTHROUGH="-Wimplicit-fallthrough=5"
-CONFIG_GCC10_NO_ARRAY_BOUNDS=y
+CONFIG_GCC11_NO_ARRAY_BOUNDS=y
 CONFIG_CC_NO_ARRAY_BOUNDS=y
 CONFIG_ARCH_SUPPORTS_INT128=y
 # CONFIG_NUMA_BALANCING is not set
@ -429,7 +428,6 @@ CONFIG_X86_INTEL_TSX_MODE_OFF=y
 # CONFIG_X86_INTEL_TSX_MODE_AUTO is not set
 CONFIG_EFI=y
 CONFIG_EFI_STUB=y
-# CONFIG_EFI_HANDOVER_PROTOCOL is not set
 CONFIG_EFI_MIXED=y
 # CONFIG_HZ_100 is not set
 # CONFIG_HZ_250 is not set
@ -463,7 +461,7 @@ CONFIG_HAVE_LIVEPATCH=y

 CONFIG_CC_HAS_SLS=y
 CONFIG_CC_HAS_RETURN_THUNK=y
-# CONFIG_CPU_MITIGATIONS is not set
+# CONFIG_SPECULATION_MITIGATIONS is not set
 CONFIG_ARCH_HAS_ADD_PAGES=y
 CONFIG_ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y

@ -620,7 +618,6 @@ CONFIG_AS_AVX512=y
 CONFIG_AS_SHA1_NI=y
 CONFIG_AS_SHA256_NI=y
 CONFIG_AS_TPAUSE=y
-CONFIG_ARCH_CONFIGURES_CPU_MITIGATIONS=y

 #
 # General architecture-dependent options
@ -868,7 +865,6 @@ CONFIG_COMPACT_UNEVICTABLE_DEFAULT=1
 CONFIG_PAGE_REPORTING=y
 CONFIG_MIGRATION=y
 CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION=y
-CONFIG_PCP_BATCH_SCALE_MAX=5
 CONFIG_PHYS_ADDR_T_64BIT=y
 CONFIG_MMU_NOTIFIER=y
 # CONFIG_KSM is not set
@ -1133,6 +1129,7 @@ CONFIG_NET_SCHED=y
 #
 # Queueing/Scheduling
 #
+# CONFIG_NET_SCH_CBQ is not set
 # CONFIG_NET_SCH_HTB is not set
 # CONFIG_NET_SCH_HFSC is not set
 # CONFIG_NET_SCH_PRIO is not set
@ -1146,6 +1143,7 @@ CONFIG_NET_SCHED=y
 # CONFIG_NET_SCH_ETF is not set
 # CONFIG_NET_SCH_TAPRIO is not set
 # CONFIG_NET_SCH_GRED is not set
+# CONFIG_NET_SCH_DSMARK is not set
 # CONFIG_NET_SCH_NETEM is not set
 # CONFIG_NET_SCH_DRR is not set
 # CONFIG_NET_SCH_MQPRIO is not set
@ -1286,6 +1284,8 @@ CONFIG_ETHTOOL_NETLINK=y
 #
 # Device Drivers
 #
+CONFIG_HAVE_EISA=y
+# CONFIG_EISA is not set
 CONFIG_HAVE_PCI=y
 CONFIG_PCI=y
 CONFIG_PCI_DOMAINS=y
@ -1899,6 +1899,9 @@ CONFIG_E1000E_HWTS=y
 # CONFIG_ICE is not set
 # CONFIG_FM10K is not set
 # CONFIG_IGC is not set
+CONFIG_NET_VENDOR_WANGXUN=y
+# CONFIG_NGBE is not set
+# CONFIG_TXGBE is not set
 # CONFIG_JME is not set
 CONFIG_NET_VENDOR_LITEX=y
 CONFIG_NET_VENDOR_MARVELL=y
@ -2000,9 +2003,6 @@ CONFIG_NET_VENDOR_VERTEXCOM=y
 CONFIG_NET_VENDOR_VIA=y
 # CONFIG_VIA_RHINE is not set
 # CONFIG_VIA_VELOCITY is not set
-CONFIG_NET_VENDOR_WANGXUN=y
-# CONFIG_NGBE is not set
-# CONFIG_TXGBE is not set
 CONFIG_NET_VENDOR_WIZNET=y
 # CONFIG_WIZNET_W5100 is not set
 # CONFIG_WIZNET_W5300 is not set
@ -2915,6 +2915,7 @@ CONFIG_BCMA_POSSIBLE=y
 # CONFIG_MFD_SM501 is not set
 # CONFIG_MFD_SKY81452 is not set
 # CONFIG_MFD_SYSCON is not set
+# CONFIG_MFD_TI_AM335X_TSCADC is not set
 # CONFIG_MFD_LP3943 is not set
 # CONFIG_MFD_LP8788 is not set
 # CONFIG_MFD_TI_LMU is not set
@ -3755,9 +3756,9 @@ CONFIG_NVMEM_SYSFS=y
 # CONFIG_PECI is not set
 # CONFIG_HTE is not set
 CONFIG_SST=y
-
+CONFIG_SST_MEMLEAK=y
 # CONFIG_SST_BOUNDS is not set
-# CONFIG_SST_ASYNC_SOURCE is not set
+# CONFIG_SST_LOCKING is not set
 # end of Device Drivers

 #
@ -3944,9 +3945,6 @@ CONFIG_KEYS=y
 # CONFIG_ENCRYPTED_KEYS is not set
 # CONFIG_KEY_DH_OPERATIONS is not set
 # CONFIG_SECURITY_DMESG_RESTRICT is not set
-CONFIG_PROC_MEM_ALWAYS_FORCE=y
-# CONFIG_PROC_MEM_FORCE_PTRACE is not set
-# CONFIG_PROC_MEM_NO_FORCE is not set
 CONFIG_SECURITY=y
 CONFIG_SECURITY_WRITABLE_HOOKS=y
 # CONFIG_SECURITYFS is not set
@ -4445,7 +4443,7 @@ CONFIG_PTDUMP_CORE=y
 # CONFIG_DEBUG_OBJECTS is not set
 # CONFIG_SHRINKER_DEBUG is not set
 CONFIG_HAVE_DEBUG_KMEMLEAK=y
-CONFIG_DEBUG_KMEMLEAK=y
+# CONFIG_DEBUG_KMEMLEAK is not set
 # CONFIG_DEBUG_STACK_USAGE is not set
 # CONFIG_SCHED_STACK_END_CHECK is not set
 CONFIG_ARCH_HAS_DEBUG_VM_PGTABLE=y
--- a/a1.2.txt
+++ b/a1.2.txt
@ -1,10 +0,0 @@
-1) a) um debug beim start des kerns zu aktivieren, reicht kern parameter (mit hilfe -a im unserem skript) zu geben dyndbg=\"module sst_chrdev +p\"
-b) gleiche idee aber statt module zu wählen, kann mann eine file und zeile auswählen wie z.B
-    dyndbg=\"file sst_chrdev.c line 40 +p; file sst_chrdev.c line 72 +p\"
-
-2) Mein grundlegendes Verständnis davon, wie kmemleak funktioniert, ist, dass jede neue Speicherzuweisung und ihre Zeiger zusammen mit einer Vielzahl von Metainformationen wie Größe verfolgt werden.
-   Informationen wie z.B. der Größe verfolgt und in einer Baumstruktur (rbtree) gespeichert wird.
-   einen Memory Allocator existiert, bedeutet dies, dass der Kernel nicht mehr in der Lage ist, ihn zu zerstören und er wird als Orphan bezeichnet.
-
-
-3) um detector standardmäßige auszuschalten, kann mann CONFIG_DEBUG_KMEMLEAK=n setzen oder entfernen im kconfig
--- a/a1.3.config
+++ b/a1.3.config
@ -1,20 +1,21 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/x86 6.1.55 Kernel Configuration
+# Linux/x86 6.1.134 Kernel Configuration
 #
-CONFIG_CC_VERSION_TEXT="gcc (Debian 13.2.0-23) 13.2.0"
+CONFIG_CC_VERSION_TEXT="gcc (Debian 12.2.0-14) 12.2.0"
 CONFIG_CC_IS_GCC=y
-CONFIG_GCC_VERSION=130200
+CONFIG_GCC_VERSION=120200
 CONFIG_CLANG_VERSION=0
 CONFIG_AS_IS_GNU=y
-CONFIG_AS_VERSION=24200
+CONFIG_AS_VERSION=24000
 CONFIG_LD_IS_BFD=y
-CONFIG_LD_VERSION=24200
+CONFIG_LD_VERSION=24000
 CONFIG_LLD_VERSION=0
 CONFIG_CC_CAN_LINK=y
 CONFIG_CC_CAN_LINK_STATIC=y
 CONFIG_CC_HAS_ASM_GOTO_OUTPUT=y
 CONFIG_CC_HAS_ASM_GOTO_TIED_OUTPUT=y
+CONFIG_GCC_ASM_GOTO_OUTPUT_WORKAROUND=y
 CONFIG_CC_HAS_ASM_INLINE=y
 CONFIG_CC_HAS_NO_PROFILE_FN_ATTR=y
 CONFIG_PAHOLE_VERSION=124
@ -175,7 +176,7 @@ CONFIG_ARCH_SUPPORTS_NUMA_BALANCING=y
 CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH=y
 CONFIG_CC_HAS_INT128=y
 CONFIG_CC_IMPLICIT_FALLTHROUGH="-Wimplicit-fallthrough=5"
-CONFIG_GCC11_NO_ARRAY_BOUNDS=y
+CONFIG_GCC10_NO_ARRAY_BOUNDS=y
 CONFIG_CC_NO_ARRAY_BOUNDS=y
 CONFIG_ARCH_SUPPORTS_INT128=y
 # CONFIG_NUMA_BALANCING is not set
@ -428,6 +429,7 @@ CONFIG_X86_INTEL_TSX_MODE_OFF=y
 # CONFIG_X86_INTEL_TSX_MODE_AUTO is not set
 CONFIG_EFI=y
 CONFIG_EFI_STUB=y
+# CONFIG_EFI_HANDOVER_PROTOCOL is not set
 CONFIG_EFI_MIXED=y
 # CONFIG_HZ_100 is not set
 # CONFIG_HZ_250 is not set
@ -461,7 +463,7 @@ CONFIG_HAVE_LIVEPATCH=y

 CONFIG_CC_HAS_SLS=y
 CONFIG_CC_HAS_RETURN_THUNK=y
-# CONFIG_SPECULATION_MITIGATIONS is not set
+# CONFIG_CPU_MITIGATIONS is not set
 CONFIG_ARCH_HAS_ADD_PAGES=y
 CONFIG_ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y

@ -618,6 +620,7 @@ CONFIG_AS_AVX512=y
 CONFIG_AS_SHA1_NI=y
 CONFIG_AS_SHA256_NI=y
 CONFIG_AS_TPAUSE=y
+CONFIG_ARCH_CONFIGURES_CPU_MITIGATIONS=y

 #
 # General architecture-dependent options
@ -865,6 +868,7 @@ CONFIG_COMPACT_UNEVICTABLE_DEFAULT=1
 CONFIG_PAGE_REPORTING=y
 CONFIG_MIGRATION=y
 CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION=y
+CONFIG_PCP_BATCH_SCALE_MAX=5
 CONFIG_PHYS_ADDR_T_64BIT=y
 CONFIG_MMU_NOTIFIER=y
 # CONFIG_KSM is not set
@ -1129,7 +1133,6 @@ CONFIG_NET_SCHED=y
 #
 # Queueing/Scheduling
 #
-# CONFIG_NET_SCH_CBQ is not set
 # CONFIG_NET_SCH_HTB is not set
 # CONFIG_NET_SCH_HFSC is not set
 # CONFIG_NET_SCH_PRIO is not set
@ -1143,7 +1146,6 @@ CONFIG_NET_SCHED=y
 # CONFIG_NET_SCH_ETF is not set
 # CONFIG_NET_SCH_TAPRIO is not set
 # CONFIG_NET_SCH_GRED is not set
-# CONFIG_NET_SCH_DSMARK is not set
 # CONFIG_NET_SCH_NETEM is not set
 # CONFIG_NET_SCH_DRR is not set
 # CONFIG_NET_SCH_MQPRIO is not set
@ -1284,8 +1286,6 @@ CONFIG_ETHTOOL_NETLINK=y
 #
 # Device Drivers
 #
-CONFIG_HAVE_EISA=y
-# CONFIG_EISA is not set
 CONFIG_HAVE_PCI=y
 CONFIG_PCI=y
 CONFIG_PCI_DOMAINS=y
@ -1899,9 +1899,6 @@ CONFIG_E1000E_HWTS=y
 # CONFIG_ICE is not set
 # CONFIG_FM10K is not set
 # CONFIG_IGC is not set
-CONFIG_NET_VENDOR_WANGXUN=y
-# CONFIG_NGBE is not set
-# CONFIG_TXGBE is not set
 # CONFIG_JME is not set
 CONFIG_NET_VENDOR_LITEX=y
 CONFIG_NET_VENDOR_MARVELL=y
@ -2003,6 +2000,9 @@ CONFIG_NET_VENDOR_VERTEXCOM=y
 CONFIG_NET_VENDOR_VIA=y
 # CONFIG_VIA_RHINE is not set
 # CONFIG_VIA_VELOCITY is not set
+CONFIG_NET_VENDOR_WANGXUN=y
+# CONFIG_NGBE is not set
+# CONFIG_TXGBE is not set
 CONFIG_NET_VENDOR_WIZNET=y
 # CONFIG_WIZNET_W5100 is not set
 # CONFIG_WIZNET_W5300 is not set
@ -2915,7 +2915,6 @@ CONFIG_BCMA_POSSIBLE=y
 # CONFIG_MFD_SM501 is not set
 # CONFIG_MFD_SKY81452 is not set
 # CONFIG_MFD_SYSCON is not set
-# CONFIG_MFD_TI_AM335X_TSCADC is not set
 # CONFIG_MFD_LP3943 is not set
 # CONFIG_MFD_LP8788 is not set
 # CONFIG_MFD_TI_LMU is not set
@ -3756,9 +3755,8 @@ CONFIG_NVMEM_SYSFS=y
 # CONFIG_PECI is not set
 # CONFIG_HTE is not set
 CONFIG_SST=y
-# CONFIG_SST_MEMLEAK is not set
-CONFIG_SST_BOUNDS=y
-# CONFIG_SST_LOCKING is not set
+# CONFIG_SST_BOUNDS is useless
+# CONFIG_SST_ASYNC_SOURCE is not set
 # end of Device Drivers

 #
@ -3945,6 +3943,9 @@ CONFIG_KEYS=y
 # CONFIG_ENCRYPTED_KEYS is not set
 # CONFIG_KEY_DH_OPERATIONS is not set
 # CONFIG_SECURITY_DMESG_RESTRICT is not set
+CONFIG_PROC_MEM_ALWAYS_FORCE=y
+# CONFIG_PROC_MEM_FORCE_PTRACE is not set
+# CONFIG_PROC_MEM_NO_FORCE is not set
 CONFIG_SECURITY=y
 CONFIG_SECURITY_WRITABLE_HOOKS=y
 # CONFIG_SECURITYFS is not set
@ -4459,7 +4460,7 @@ CONFIG_HAVE_ARCH_KASAN=y
 CONFIG_HAVE_ARCH_KASAN_VMALLOC=y
 CONFIG_CC_HAS_KASAN_GENERIC=y
 CONFIG_CC_HAS_WORKING_NOSANITIZE_ADDRESS=y
-# CONFIG_KASAN is not set
+CONFIG_KASAN=y
 CONFIG_HAVE_ARCH_KFENCE=y
 # CONFIG_KFENCE is not set
 CONFIG_HAVE_ARCH_KMSAN=y
--- a/a1.txt
+++ b/a1.txt
@ -0,0 +1,10 @@
+a) Inline: KASAN istrumentationt ist im code ausführung eingesetzt,
+    um mehr Präzision bei der Erkennung von Speicherfehlern zu erreichen, während die Leistung ein wenig darunter leidet
+    Outline : Instrumentierungsbezogener Code wird in einer separaten Funktion ausgeführt, wobei die Präzision zugunsten der Leistung geopfert wird.
+
+ b) Die wichtigste Information in den Kernel-Logs war der Stack-Trace,
+  gab mir Informationen über den Übeltäter,
+  außerdem enthielt der write-fehler Informationen über die Größe,
+   und es wurde angedeutet, dass versucht wurde, außerhalb der bufferedbound zuzugreifen.
+   für die read fehler, Die Größe der von Kasan gemeldeten Daten im Vergleich zur Größe der mit pr_debug angezeigten Daten verrät,
+    dass die Anzahl der lokalen Variablen das Problem ist.
--- a/drivers/sst/Makefile
+++ b/drivers/sst/Makefile
@ -4,3 +4,6 @@
 #

 obj-$(CONFIG_SST)	+= sst_chrdev.o boundedbuffer.o sst_common.o
+CFLAGS_sst_chrdev.o := -DDEBUG
+CFLAGS_sst_common.o := -DDEBUG
+CFLAGS_boundedbuffer.o := -DDEBUG
--- a/drivers/sst/boundedbuffer.c
+++ b/drivers/sst/boundedbuffer.c
@ -1,10 +1,8 @@
 #include "sst_internal.h"

-#ifdef CONFIG_SST_BOUNDS
-#define OFFSET (4 * BOUNDEDBUFFER_SIZE)
-#else
+//this is diabloical
 #define OFFSET 0
-#endif
+

 void init_bbuffer(struct boundedbuffer *buffer) {
 	buffer->next_in = 0;
--- a/drivers/sst/sst_chrdev.c
+++ b/drivers/sst/sst_chrdev.c
@ -1,12 +1,9 @@
 #include "sst_internal.h"
-#include "../../include/linux/slab.h"
-
 #include <linux/module.h>
 #include <linux/device.h>
 #include <linux/fs.h>
 #include <linux/uaccess.h>
 #include <linux/cdev.h>
-#include <linux/slab.h>

 #define	SST_CHRDEV "the-universe"

@ -28,26 +25,21 @@ static ssize_t universe_read(struct file *file, char __user *buf, size_t count,
 		       loff_t *ppos) {
 	struct sst_info *sst_info = (struct sst_info*)file->private_data;
 	char *answer = NULL;
-	int min = 0;
 	size_t len = 0;

 	if (sst_consume_answer(sst_info, &answer)) {
 		pr_debug("Cannot read from answers!\n");
-		kfree(answer);
 		return 0;
 	}
 	len = strlen(answer);
 	sst_debug("About to copy %lu bytes of your answer at 0x%lx to the userspace\n", len, (uintptr_t)answer);
-	min = min(len, count);
-	if (min != len) {
-		pr_err("Sorry, your buffer is %lu bytes too small.\n", len - min);
-	}
-	if (copy_to_user(buf, answer, min)) {
+	size_t toCopy = min(count, len);
+	if (copy_to_user(buf, answer, toCopy)) {
 		pr_err("User copy failed!\n");
 		kfree(answer);
 		return -EFAULT;
 	}
-	sst_debug("Copied %u bytes of your answer to the userspace: %s\n", min, answer);
+	sst_debug("Copied %lu bytes of your answer to the userspace: %s\n", count, answer);
 	*ppos += len;
 	kfree(answer);
 	return len;
@ -66,11 +58,9 @@ static ssize_t universe_write(struct file *file, const char __user *buf, size_t
 	err = sst_produce_question(sst_info, buf_copy);
 	if (err) {
 		pr_err("Weird! The universe is full.\n");
-		kfree(buf_copy);
 		return -ENOMEM;
 	}
 	sst_debug("Asked the universe a question...\n");
-	kfree(buf_copy);
 	return count;
 }

--- a/drivers/sst/sst_common.c
+++ b/drivers/sst/sst_common.c
@ -82,6 +82,7 @@ static int control_thread_work(void *data) {
 		sst_debug("Randomly sleeping for %d secs. ZzzzZZzz\n", sleep);
 		ssleep(sleep);
 #endif
+		kfree(question);
 	}

 	return 0;
Author	SHA1	Message	Date
hamza	ed8f1d31a7	- fixed buffers size	2025-05-21 14:10:38 +02:00
hamza	8d67347001	all changes relevant to exercise a1.3	2025-05-12 18:33:41 +02:00
Alexander Lochmann	b949dcd4b5	Backports sst fixes	2025-04-25 16:23:01 +02:00
Alexander Lochmann	6b1c633623	Updated a1.3.config	2025-04-17 20:15:32 +02:00
Alexander Lochmann	45cb823c25	Merge remote-tracking branch 'origin/linux-6.1.y' into a1.3	2025-04-17 19:49:51 +02:00
Alexander Lochmann	f96e9ca205	sst: Quick port of recent fixes from sst branch	2024-05-08 12:34:05 +02:00
Alexander Lochmann	d28ffd9c3c	Bounds do not matter!	2024-05-02 14:36:01 +02:00