hamza.kesraoui/sst-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
16d6b2527f
sst-linux/arch/x86/kernel
History
Vladis Dronov 34988d2e0c x86/sgx: Warn explicitly if X86_FEATURE_SGX_LC is not enabled 
[ Upstream commit 65be5c95d08eedda570a6c888a12384c77fe7614 ]

The kernel requires X86_FEATURE_SGX_LC to be able to create SGX enclaves,
not just X86_FEATURE_SGX.

There is quite a number of hardware which has X86_FEATURE_SGX but not
X86_FEATURE_SGX_LC. A kernel running on such hardware does not create
the /dev/sgx_enclave file and does so silently.

Explicitly warn if X86_FEATURE_SGX_LC is not enabled to properly notify
users that the kernel disabled the SGX driver.

The X86_FEATURE_SGX_LC, a.k.a. SGX Launch Control, is a CPU feature
that enables LE (Launch Enclave) hash MSRs to be writable (with
additional opt-in required in the 'feature control' MSR) when running
enclaves, i.e. using a custom root key rather than the Intel proprietary
key for enclave signing.

I've hit this issue myself and have spent some time researching where
my /dev/sgx_enclave file went on SGX-enabled hardware.

Related links:

  https://github.com/intel/linux-sgx/issues/837
  https://patchwork.kernel.org/project/platform-driver-x86/patch/20180827185507.17087-3-jarkko.sakkinen@linux.intel.com/

[ mingo: Made the error message a bit more verbose, and added other cases
         where the kernel fails to create the /dev/sgx_enclave device node. ]

Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Kai Huang <kai.huang@intel.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250309172215.21777-2-vdronov@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-04-10 14:33:39 +02:00
..
acpi ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors 2024-03-26 18:20:39 -04:00
apic x86/apic: Always explicitly disarm TSC-deadline timer 2024-10-22 15:56:50 +02:00
cpu x86/sgx: Warn explicitly if X86_FEATURE_SGX_LC is not enabled 2025-04-10 14:33:39 +02:00
fpu x86/fpu/xstate: Fix inconsistencies in guest FPU xfeatures 2025-04-10 14:33:31 +02:00
kprobes kprobes/x86: Use copy_from_kernel_nofault() to read from unsafe address 2024-04-03 15:19:45 +02:00
.gitignore
alternative.c x86/alternative: Make custom return thunk unconditional 2024-03-01 13:26:33 +01:00
amd_gart_64.c x86/mm: Remove P*D_PAGE_MASK and P*D_PAGE_SIZE macros 2024-04-27 17:07:06 +02:00
amd_nb.c x86/amd_nb: Use rdmsr_safe() in amd_get_mmconfig_range() 2025-03-13 12:53:11 +01:00
aperture_64.c
apm_32.c x86/APM: drop the duplicate APM_MINOR_DEV macro 2023-09-13 09:42:52 +02:00
asm-offsets_32.c
asm-offsets_64.c
asm-offsets.c
audit_64.c
bootflag.c
cfi.c
check.c
cpuid.c
crash_core_32.c
crash_core_64.c
crash_dump_32.c
crash_dump_64.c
crash.c x86/reboot: VMCLEAR active VMCSes before emergency reboot 2023-10-06 14:56:50 +02:00
devicetree.c x86/of: Return consistent error type from x86_of_pci_irq_enable() 2024-08-03 08:48:53 +02:00
doublefault_32.c
dumpstack_32.c x86/32: Remove CONFIG_DOUBLEFAULT 2020-04-14 14:24:05 +02:00
dumpstack_64.c
dumpstack.c x86/dumpstack: Fix inaccurate unwinding from exception stacks due to misplaced assignment 2025-04-10 14:33:35 +02:00
e820.c x86/e820: Don't reserve SETUP_RNG_SEED in e820 2024-03-06 14:45:11 +00:00
early_printk.c
early-quirks.c
ebda.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
eisa.c x86/sev: Skip ROM range scans and validation for SEV-SNP guests 2024-04-03 15:19:55 +02:00
espfix_64.c
ftrace_32.S
ftrace_64.S
ftrace.c x86/returnthunk: Allow different return thunks 2024-03-01 13:26:33 +01:00
head32.c x86/boot: Mostly revert commit ae7e1238e6 ("Add ACPI RSDP address to setup_header") 2018-11-20 09:43:10 +01:00
head64.c x86/head/64: Move the __head definition to <asm/init.h> 2024-04-27 17:07:07 +02:00
head_32.S
head_64.S
hpet.c rtc: Add support for configuring the UIP timeout for RTC reads 2024-01-31 16:17:01 -08:00
hw_breakpoint.c
i8237.c
i8253.c x86/i8253: Disable PIT timer 0 when not in use 2025-02-21 13:50:12 +01:00
i8259.c x86/i8259: Skip probing when ACPI/MADT advertises PCAT compatibility 2023-11-02 09:35:31 +01:00
idt.c x86/entry: Convert INT 0x80 emulation to IDTENTRY 2023-12-13 18:39:05 +01:00
io_delay.c
ioport.c
irq_32.c
irq_64.c
irq_work.c x86/entry: Convert various system vectors 2020-06-11 15:15:14 +02:00
irq.c x86/irq: Define trace events conditionally 2025-03-28 21:58:53 +01:00
irqflags.S x86: Prepare asm files for straight-line-speculation 2021-12-08 12:25:37 +01:00
irqinit.c
itmt.c
jailhouse.c
jump_label.c
kdebugfs.c
kexec-bzimage64.c
kgdb.c
ksysfs.c
kvm.c x86/sev: Make enc_dec_hypercall() accept a size instead of npages 2023-09-13 09:43:03 +02:00
kvmclock.c x86/kvm: Do not try to disable kvmclock if it was not enabled 2024-01-25 15:27:44 -08:00
ldt.c
machine_kexec_32.c x86/kexec: Set_[gi]dt() -> native_[gi]dt_invalidate() in machine_kexec_*.c 2021-05-21 12:36:45 +02:00
machine_kexec_64.c x86/kexec: Allocate PGD for x86_64 transition page tables separately 2025-02-21 13:49:33 +01:00
Makefile
mmconf-fam10h_64.c
module.c treewide: use prandom_u32_max() when possible, part 1 2022-10-11 17:42:55 -06:00
mpparse.c x86: Avoid magic number with ELCR register accesses 2021-08-10 23:31:43 +02:00
msr.c
nmi_selftest.c
nmi.c x86/bugs: Use ALTERNATIVE() instead of mds_user_clear static key 2024-03-06 14:45:20 +00:00
paravirt-spinlocks.c
paravirt.c
pci-dma.c
pcspeaker.c x86/platform/pcspeaker: Use PTR_ERR_OR_ZERO() to fix ptr_ret.cocci warning 2018-07-24 09:46:42 +02:00
perf_regs.c
platform-quirks.c x86/quirks: Include linux/pnp.h for arch_pnpbios_disabled() 2024-04-27 17:07:10 +02:00
pmem.c x86/pmem: Fix platform-device leak in error path 2022-06-20 18:01:16 +02:00
probe_roms.c x86/sev: Skip ROM range scans and validation for SEV-SNP guests 2024-04-03 15:19:55 +02:00
process_32.c
process_64.c x86/cpu: Fix check for RDPKRU in __show_regs() 2024-05-02 16:29:27 +02:00
process.c x86/fpu: Avoid copying dynamic FP state from init_task in arch_dup_task_struct() 2025-04-10 14:33:30 +02:00
process.h x86: Snapshot thread flags 2021-12-01 00:06:43 +01:00
ptrace.c
pvclock.c
quirks.c
reboot_fixups_32.c
reboot.c x86/reboot: VMCLEAR active VMCSes before emergency reboot 2023-10-06 14:56:50 +02:00
relocate_kernel_32.S
relocate_kernel_64.S
resource.c
rethook.c
rtc.c rtc: Extend timeout for waiting for UIP to clear to 1s 2024-01-31 16:17:01 -08:00
setup_percpu.c mm: percpu: add generic pcpu_populate_pte() function 2022-01-20 08:52:52 +02:00
setup.c x86/coco: Require seeding RNG with RDRAND on CoCo systems 2024-04-10 16:28:33 +02:00
sev_verify_cbit.S
sev-shared.c x86/sev: Move early startup code into .head.text section 2024-04-27 17:07:07 +02:00
sev.c x86/sev: Move early startup code into .head.text section 2024-04-27 17:07:07 +02:00
signal_compat.c
signal.c x86/init: Initialize signal frame size late 2023-08-08 20:03:47 +02:00
smp.c x86/smp: Cure kexec() vs. mwait_play_dead() breakage 2023-07-01 13:16:23 +02:00
smpboot.c x86/smp: Cure kexec() vs. mwait_play_dead() breakage 2023-07-01 13:16:23 +02:00
stacktrace.c x86: remove __range_not_ok() 2022-02-25 09:36:05 +01:00
static_call.c x86/static-call: Remove early_boot_irqs_disabled check to fix Xen PVH dom0 2025-02-21 13:50:09 +01:00
step.c
sys_ia32.c
sys_x86_64.c
tboot.c
time.c x86: stop playing stack games in profile_pc() 2024-07-05 09:31:51 +02:00
tls.c
tls.h x86: switch to ->regset_get() 2020-07-27 14:31:07 -04:00
topology.c
trace_clock.c
trace.c
tracepoint.c
traps.c x86/CPU/AMD: Fix the DIV(0) initial fix attempt 2023-08-26 13:27:00 +02:00
tsc_msr.c Misc fixes and small updates all around the place: 2020-08-15 10:38:03 -07:00
tsc_sync.c x86/tsc: Trust initial offset in architectural TSC-adjust MSRs 2024-06-12 11:02:54 +02:00
tsc.c x86/tsc: Be consistent about use_tsc_delay() 2022-03-15 18:20:33 +01:00
umip.c x86/umip: Downgrade warning messages to debug loglevel 2021-09-25 13:23:28 +02:00
unwind_frame.c x86: kmsan: don't instrument stack walking functions 2022-10-03 14:03:25 -07:00
unwind_guess.c x86/unwind: Recover kretprobe trampoline entry 2021-09-30 21:24:07 -04:00
unwind_orc.c x86/unwind/orc: Fix unreliable stack dump with gcov 2022-10-21 14:56:42 +02:00
uprobes.c
verify_cpu.S
vm86_32.c
vmlinux.lds.S x86/retpoline,kprobes: Fix position of thunk sections with CONFIG_LTO_CLANG 2023-08-26 13:27:00 +02:00
vsmp_64.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 346 2019-06-05 17:37:08 +02:00
x86_init.c x86/sev: Skip ROM range scans and validation for SEV-SNP guests 2024-04-03 15:19:55 +02:00