Daniel Borkmann 8397bf7898 bpf: Zero former ARG_PTR_TO_{LONG,INT} args in case of error ... [ Upstream commit 4b3786a6c5397dc220b1483d8e2f4867743e966f ] For all non-tracing helpers which formerly had ARG_PTR_TO_{LONG,INT} as input arguments, zero the value for the case of an error as otherwise it could leak memory. For tracing, it is not needed given CAP_PERFMON can already read all kernel memory anyway hence bpf_get_func_arg() and bpf_get_func_ret() is skipped in here. Also, the MTU helpers mtu_len pointer value is being written but also read. Technically, the MEM_UNINIT should not be there in order to always force init. Removing MEM_UNINIT needs more verifier rework though: MEM_UNINIT right now implies two things actually: i) write into memory, ii) memory does not have to be initialized. If we lift MEM_UNINIT, it then becomes: i) read into memory, ii) memory must be initialized. This means that for bpf_*_check_mtu() we're readding the issue we're trying to fix, that is, it would then be able to write back into things like .rodata BPF maps. Follow-up work will rework the MEM_UNINIT semantics such that the intent can be better expressed. For now just clear the *mtu_len on error path which can be lifted later again. Fixes: 8a67f2de9b ("bpf: expose bpf_strtol and bpf_strtoul to all program types") Fixes: d7a4cb9b67 ("bpf: Introduce bpf_strtol and bpf_strtoul helpers") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/e5edd241-59e7-5e39-0ee5-a51e31b6840a@iogearbox.net Link: https://lore.kernel.org/r/20240913191754.13290-5-daniel@iogearbox.net Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-10-17 15:21:00 +02:00
..
bpf	bpf: Zero former ARG_PTR_TO_{LONG,INT} args in case of error	2024-10-17 15:21:00 +02:00
cgroup	cgroup: Protect css->cgroup write under css_set_lock	2024-09-12 11:10:22 +02:00
configs
debug	kdb: Use the passed prompt in kdb_position_cursor()	2024-08-03 08:49:47 +02:00
dma	dma-mapping: benchmark: Don't starve others when doing the test	2024-09-12 11:10:23 +02:00
entry	entry: Respect changes to system call number by trace_sys_enter()	2024-04-03 15:19:44 +02:00
events	perf/aux: Fix AUX buffer serialization	2024-09-12 11:10:27 +02:00
futex	futex: Don't include process MM in futex key on no-MMU	2023-11-20 11:51:50 +01:00
gcov	gcov: add support for GCC 14	2024-06-27 13:46:22 +02:00
irq	genirq/irqdesc: Honor caller provided affinity in alloc_desc()	2024-08-14 13:52:58 +02:00
kcsan	kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures	2023-07-19 16:21:37 +02:00
livepatch	livepatch: Fix missing newline character in klp_resolve_symbols()	2023-11-20 11:52:10 +01:00
locking	rtmutex: Drop rt_mutex::wait_lock before scheduling	2024-09-12 11:10:17 +02:00
module	modules: wait do_free_init correctly	2024-03-26 18:20:52 -04:00
power	PM: s2idle: Make sure CPUs will wakeup directly on resume	2024-04-17 11:18:22 +02:00
printk	printk: Update @console_may_schedule in console_trylock_spinning()	2024-04-03 15:19:44 +02:00
rcu	rcu/nocb: Fix RT throttling hrtimer armed from offline CPU	2024-10-17 15:20:49 +02:00
sched	sched/smt: Fix unbalance sched_smt_present dec/inc	2024-08-14 13:53:00 +02:00
time	hrtimer: Prevent queuing of hrtimer without a function callback	2024-08-29 17:30:41 +02:00
trace	tracing: Avoid possible softlockup in tracing_iter_reset()	2024-09-12 11:10:18 +02:00
.gitignore
acct.c	acct: fix potential integer overflow in encode_comp_t()	2022-12-31 13:32:58 +01:00
async.c	async: Introduce async_schedule_dev_nocall()	2024-01-31 16:17:00 -08:00
audit_fsnotify.c
audit_tree.c	audit: use fsnotify group lock helpers	2022-04-25 14:37:28 +02:00
audit_watch.c	audit: don't WARN_ON_ONCE(!current->mm) in audit_exe_compare()	2023-11-28 17:07:08 +00:00
audit.c	audit: Send netlink ACK before setting connection in auditd_set	2024-02-05 20:12:47 +00:00
audit.h
auditfilter.c	ima: Avoid blocking in RCU read-side critical section	2024-07-11 12:47:16 +02:00
auditsc.c	audit,io_uring: io_uring openat triggers audit reference count underflow	2023-10-25 12:03:04 +02:00
backtracetest.c
bounds.c	bounds: Use the right number of bits for power-of-two CONFIG_NR_CPUS	2024-05-02 16:29:32 +02:00
capability.c
cfi.c
compat.c	sched_getaffinity: don't assume 'cpumask_size()' is fully initialized	2023-04-06 12:10:40 +02:00
configs.c	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
context_tracking.c	context_tracking: Fix noinstr vs KASAN	2023-03-10 09:33:45 +01:00
cpu_pm.c	context_tracking: Take IRQ eqs entrypoints over RCU	2022-07-05 13:32:59 -07:00
cpu.c	cpu/hotplug: Fix dynstate assignment in __cpuhp_setup_state_cpuslocked()	2024-07-05 09:31:56 +02:00
crash_core.c	vmcoreinfo: add kallsyms_num_syms symbol	2022-08-28 14:02:44 -07:00
crash_dump.c
cred.c	cred: switch to using atomic_long_t	2023-12-20 17:00:20 +01:00
delayacct.c
dma.c
exec_domain.c
exit.c	mm: optimize the redundant loop of mm_update_owner_next()	2024-07-11 12:47:13 +02:00
extable.c	context_tracking: Take NMI eqs entrypoints over RCU	2022-07-05 13:32:59 -07:00
fail_function.c	kernel/fail_function: fix memory leak with using debugfs_lookup()	2023-03-11 13:55:39 +01:00
fork.c	Revert "fork: defer linking file vma until vma is fully initialized"	2024-06-21 14:35:59 +02:00
freezer.c	freezer,sched: Rewrite core freezer logic	2022-09-07 21:53:50 +02:00
gen_kheaders.sh	kheaders: explicitly define file modes for archived headers	2024-06-27 13:46:24 +02:00
groups.c
hung_task.c
iomem.c
irq_work.c
jump_label.c	jump_label: Fix the fix, brown paper bags galore	2024-08-14 13:52:43 +02:00
kallsyms_internal.h	kallsyms: Reduce the memory occupied by kallsyms_seqs_of_names[]	2023-10-25 12:03:16 +02:00
kallsyms.c	kallsyms: Add helper kallsyms_on_each_match_symbol()	2023-10-25 12:03:16 +02:00
kcmp.c
Kconfig.freezer	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Kconfig.hz
Kconfig.locks	locking/rwlock: Provide RT variant	2021-08-17 17:50:51 +02:00
Kconfig.preempt
kcov.c	kcov: properly check for softirq context	2024-08-14 13:52:58 +02:00
kexec_core.c	kexec: fix a memory leak in crash_shrink_memory()	2023-07-19 16:21:08 +02:00
kexec_elf.c	kexec_elf: support 32 bit ELF files	2019-09-06 23:58:44 +02:00
kexec_file.c	kexec: support purgatories with .text.hot sections	2023-06-21 16:00:55 +02:00
kexec_internal.h
kexec.c	kernel: kexec: copy user-array safely	2023-11-28 17:06:57 +00:00
kheaders.c	kheaders: Use array declaration instead of char	2023-05-11 23:03:02 +09:00
kmod.c
kprobes.c	kprobes: Fix to check symbol prefixes correctly	2024-08-14 13:52:54 +02:00
ksysfs.c
kthread.c	kthread: fix task state in kthread worker if being frozen	2024-10-17 15:20:58 +02:00
latencytop.c	latencytop: use the last element of latency_record of system	2022-09-11 21:55:12 -07:00
Makefile	kernel/numa.c: Move logging out of numa.h	2024-06-12 11:03:16 +02:00
module_signature.c	module: harden ELF info handling	2021-01-19 10:24:45 +01:00
notifier.c	notifier: Add blocking/atomic_notifier_chain_register_unique_prio()	2022-05-19 19:30:30 +02:00
nsproxy.c	Revert "fs/exec: allow to unshare a time namespace on vfork+exec"	2022-09-13 10:38:43 -07:00
numa.c	kernel/numa.c: Move logging out of numa.h	2024-06-12 11:03:16 +02:00
padata.c	padata: Honor the caller's alignment in case of chunk_size 0	2024-10-17 15:20:38 +02:00
panic.c	panic: Flush kernel log buffer at the end	2024-04-13 13:04:54 +02:00
params.c
pid_namespace.c	pid: Replace struct pid 1-element array with flex-array	2024-08-29 17:30:18 +02:00
pid.c	pid: Replace struct pid 1-element array with flex-array	2024-08-29 17:30:18 +02:00
profile.c	profiling: remove profile=sleep support	2024-08-14 13:52:50 +02:00
ptrace.c
range.c
reboot.c	kernel/reboot: emergency_restart: Set correct system_state	2023-11-28 17:07:13 +00:00
regset.c	regset: kill ->get()	2020-07-27 14:31:12 -04:00
relay.c	relayfs: fix out-of-bounds access in relay_file_read	2023-05-11 23:03:03 +09:00
resource_kunit.c	resource: provide meaningful MODULE_LICENSE() in test suite	2020-11-25 18:52:35 +01:00
resource.c	x86/kaslr: Expose and use the end of the physical memory address space	2024-09-12 11:10:17 +02:00
rseq.c
scftorture.c	scftorture: Forgive memory-allocation failure if KASAN	2023-09-23 11:11:00 +02:00
scs.c
seccomp.c	seccomp: Add wait_killable semantic to seccomp user notifier	2022-05-03 14:11:58 -07:00
signal.c	kernel: rerun task_work while freezing in get_signal()	2024-08-03 08:49:31 +02:00
smp.c	smp: Add missing destroy_work_on_stack() call in smp_call_on_cpu()	2024-09-12 11:10:24 +02:00
smpboot.c
smpboot.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
softirq.c	softirq: Fix suspicious RCU usage in __do_softirq()	2024-06-12 11:03:01 +02:00
stackleak.c
stacktrace.c
static_call_inline.c	static_call: Don't make __static_call_return0 static	2022-04-05 09:59:38 +02:00
static_call.c	static_call: Don't make __static_call_return0 static	2022-04-05 09:59:38 +02:00
stop_machine.c
sys_ni.c	syscalls: fix compat_sys_io_pgetevents_time64 usage	2024-07-05 09:31:59 +02:00
sys.c	getrusage: use sig->stats_lock rather than lock_task_sighand()	2024-03-15 10:48:22 -04:00
sysctl-test.c	kernel/sysctl-test: use SYSCTL_{ZERO/ONE_HUNDRED} instead of i_{zero/one_hundred}	2022-09-08 16:56:45 -07:00
sysctl.c
task_work.c	task_work: Introduce task_work_cancel() again	2024-08-03 08:49:34 +02:00
taskstats.c
torture.c	torture: Fix hang during kthread shutdown phase	2023-03-10 09:34:07 +01:00
tracepoint.c
tsacct.c	taskstats: version 12 with thread group and exe info	2022-04-29 14:38:03 -07:00
ucount.c
uid16.c
uid16.h
umh.c	freezer,umh: Fix call_usermode_helper_exec() vs SIGKILL	2023-02-22 12:59:50 +01:00
up.c	A set of locking related fixes and updates:	2021-05-09 13:07:03 -07:00
user_namespace.c
user-return-notifier.c
user.c	fs/epoll: use a per-cpu counter for user's watches count	2021-09-08 11:50:27 -07:00
usermode_driver.c
utsname_sysctl.c
utsname.c	uts: Use generic ns_common::count	2020-08-19 14:13:20 +02:00
watch_queue.c	kernel: watch_queue: copy user-array safely	2023-11-28 17:06:57 +00:00
watchdog_hld.c	watchdog/perf: properly initialize the turbo mode timestamp and rearm counter	2024-08-03 08:49:42 +02:00
watchdog.c	watchdog: move softlockup_panic back to early_param	2023-11-28 17:07:09 +00:00
workqueue_internal.h	workqueue: Assign a color to barrier work items	2021-08-17 07:49:10 -10:00
workqueue.c	workqueue: Improve scalability of workqueue watchdog touch	2024-09-12 11:10:27 +02:00