sst-linux/tools
Ido Schimmel 7a850dd2de ipv4: Fix incorrect TOS in fibmatch route get reply
[ Upstream commit f036e68212c11e5a7edbb59b5e25299341829485 ]

The TOS value that is returned to user space in the route get reply is
the one with which the lookup was performed ('fl4->flowi4_tos'). This is
fine when the matched route is configured with a TOS as it would not
match if its TOS value did not match the one with which the lookup was
performed.

However, matching on TOS is only performed when the route's TOS is not
zero. It is therefore possible to have the kernel incorrectly return a
non-zero TOS:

 # ip link add name dummy1 up type dummy
 # ip address add 192.0.2.1/24 dev dummy1
 # ip route get fibmatch 192.0.2.2 tos 0xfc
 192.0.2.0/24 tos 0x1c dev dummy1 proto kernel scope link src 192.0.2.1

Fix by instead returning the DSCP field from the FIB result structure
which was populated during the route lookup.

Output after the patch:

 # ip link add name dummy1 up type dummy
 # ip address add 192.0.2.1/24 dev dummy1
 # ip route get fibmatch 192.0.2.2 tos 0xfc
 192.0.2.0/24 dev dummy1 proto kernel scope link src 192.0.2.1

Extend the existing selftests to not only verify that the correct route
is returned, but that it is also returned with correct "tos" value (or
without it).

Fixes: b61798130f ("net: ipv4: RTM_GETROUTE: return matched fib result when requested")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-08-03 08:49:24 +02:00
..
accounting
arch x86/insn: Add VEX versions of VPDPBUSD, VPDPBUSDS, VPDPWSSD and VPDPWSSDS 2024-06-12 11:03:30 +02:00
bootconfig
bpf bpftool: Mount bpffs when pinmaps path not under the bpffs 2024-08-03 08:49:07 +02:00
build
certs
cgroup
counter
debugging
edid
firewire
firmware
gpio
hv
iio tools: iio: replace seekdir() in iio_generic_buffer 2024-04-13 13:05:16 +02:00
include bpf: Pack struct bpf_fib_lookup 2024-06-12 11:03:08 +02:00
io_uring
kvm/kvm_stat
laptop
leds
lib libbpf: Checking the btf_type kind when fixing variable offsets 2024-08-03 08:49:06 +02:00
memory-model
objtool
pci
pcmcia
perf perf intel-pt: Fix exclude_guest setting 2024-08-03 08:49:15 +02:00
power tools/power/cpupower: Fix Pstate frequency reporting on AMD Family 1Ah CPUs 2024-07-25 09:49:08 +02:00
rcu
scripts
spi
testing ipv4: Fix incorrect TOS in fibmatch route get reply 2024-08-03 08:49:24 +02:00
thermal
time
tracing tools/latency-collector: Fix -Wformat-security compile warns 2024-06-12 11:02:56 +02:00
usb
verification
virtio
vm
wmi
Makefile